Update UI interactions #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proy30
force-pushed
the
dashboard/update_ui_interactions
branch
from
6cc5b59 to
64ac002
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/python/impactx/dashboard/Input/space_charge_configuration/spaceChargeMain.py
Fixed
Show fixed
Hide fixed
|
Prior to PR changes: chrome_ESuhsgwsjA.mp4After: chrome_merK8fKIZJ.mp4 |
|
Merge after #780 |
|
Very cool PR, thanks also for the video in the comment to demonstrate! #780 is in, ready for rebase. |
User values are preserved rather than resetting every time max_level or poisson_solver changes.
proy30
force-pushed
the
dashboard/update_ui_interactions
branch
from
76b69e2 to
eb0998d
Compare
proy30
force-pushed
the
dashboard/update_ui_interactions
branch
from
a8eb6f2 to
82f57ac
Compare
|
Rebased, ready to go! :) @ax3l |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Distribution parameters are preserved when only the distribution name is changed. Currently, distribution parameters are reset to the default every time the distribution name is changed, regardless of name.
- Additionally, made modification to ensure no parameters are shown when the distribution is set to
Empty. Currently, it is set to "Twiss"- Similarly with distribution interactions, currently the UI will reset any user inputs for
prob_relativewhenever thepoisson_solverormax_levelfields are changed. This is now solved, where theprob_relativefields will have it's values preserved.