[Draft] File Importing #785
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was not properly displaying the correct information when both space charge and csr were selected
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| to the dashboard and auto-populate the UI with their configurations. | ||
| """ | ||
|
|
||
| def file_details(file) -> None: |
Check notice
Code scanning / CodeQL
First parameter of a method is not named 'self' Note
| elif file_size_in_bytes < 1024 * 1024: | ||
| size_str = f"{file_size_in_bytes/1024:.1f} KB" | ||
|
|
||
| state.import_file_details = f"({size_str}) {file['name']}" |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
|
|
||
| state.import_file_details = f"({size_str}) {file['name']}" | ||
|
|
||
| def parse_impactx_simulation_file(file) -> None: |
Check notice
Code scanning / CodeQL
First parameter of a method is not named 'self' Note
|
|
||
| return parsed_values_dictionary | ||
|
|
||
| def populate_impactx_simulation_file_to_ui(file) -> None: |
Check notice
Code scanning / CodeQL
First parameter of a method is not named 'self' Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to upload .py simulation files and have the dashboard auto-populate inputs based on sim file info. The parser currently expects input files to be structured in the same structure as the dashboard export files.
Current limitations:
sim.lattice.extendandsim.lattice.append). The initial parser is limited - can only correctly all extract elements if the input file is structured similar to the export file.Merge after #780
Takes care of #668