Python: Mixin Elements Submodule #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
component: elements
Move the mixin elements (non-physical, mostly helper methods and attributes) to `impactx.elements.mixin` to avoid that they are listed by default and, e.g., picked up in the GUI as physical elements.
ax3l
force-pushed
the
topic-py-mixin-submodule
branch
from
8180bba to
3f68b42
Compare
ax3l
commented
Jan 7, 2025
| "Mixin classes for accelerator lattice elements in ImpactX" | ||
| ); | ||
|
|
||
| py::class_<elements::Named>(mx, "Named") |
There was a problem hiding this comment.
@proy30 just FYI: the mixin classes (Named, Thick, Thin, Alignment) should not be selectable as "physical elements" in the accelerator lattice by the user in the GUI. This change should do that automatically now.
proy30
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the mixin elements (non-physical, mostly helper methods and attributes) to
impactx.elements.mixinto avoid that they are listed by default and, e.g., picked up in the GUI as physical elements.