-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pydantic v2 #192
Conversation
Conform to Python 3.9+ typing formatting.
Remove minimum expected version (this is already handled by the requirements and version specifiers there). Remove filterwarnings. Remove showing the 10 slowest tests when running pytest, and update to show the missing lines in the code coverage overview as well as the coverage.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 88.67% 89.80% +1.12%
==========================================
Files 15 15
Lines 459 451 -8
==========================================
- Hits 407 405 -2
+ Misses 52 46 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is momentarily put on hold/delayed until its impact on current project deliverables depending on this plugin have been determined and cleared. |
So I've tested this branch with the TEM demo and found that no changes were really necessary, other than ensuring all dependencies support Pydantic v2. In conclusion, I think there is no issue with merging this PR, other than letting any users know that they should ensure they have the following minimum dependencies:
|
@francescalb Gentle reminder that this has been texted externally and poses no apparent issues - other than assuring the latest versions are used for all OTEAPI-related packages after merging and updating the version. And possibly upgrade plugins as otherwise expected to support pydantic v2 if the depend on |
…te-to-pydantic-v2
…te-to-pydantic-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Description:
Closes #187
Update to use pydantic v2:
oteapi-core
>=0.6.0otelib
>=0.4.0typing.Annotated
throughout as this is recommended.pyupgrade --py39-plus
.Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.