Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation preparation #209

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Conversation

CasperWA
Copy link
Contributor

Description:

Closes #83
Closes #196

Update the way the API reference is updated in the documentation.
Update the all_strategies.md file to actually include all strategies.
Remove the now unused invoke tasks related to update the API reference and landing page in the documentation.

Add a line in the README referencing the documentation page including all strategies.
Update the link used for the above reference to be relative when generating the documentation landing page.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand, including clearly named variables?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Use SINTEF/ci-cd pre-commit hooks.
Remove the invoke tasks.

Update options for the documentation file that showcases all the
strategies.
@CasperWA CasperWA requested a review from francescalb January 22, 2024 10:24
Ensure everything is shown, even if it has no explicit doc-string.
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (777cea7) 88.67% compared to head (63759c7) 88.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files          15       15           
  Lines         459      459           
=======================================
  Hits          407      407           
  Misses         52       52           
Flag Coverage Δ
linux 88.67% <ø> (ø)
windows 88.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CasperWA CasperWA requested review from ajeklund and removed request for francescalb February 2, 2024 10:10
@CasperWA CasperWA requested a review from francescalb February 23, 2024 07:24
Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and renders well for me locally.

@CasperWA CasperWA merged commit 8e75de5 into master Feb 23, 2024
10 checks passed
@CasperWA CasperWA deleted the cwa/close-83-196-documentation branch February 23, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document functionality/features Reenable update-docs-api-reference in ci workflow
3 participants