Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bundle size by replacing react-icons #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve bundle size by replacing react-icons #104

wants to merge 1 commit into from

Conversation

MrToph
Copy link

@MrToph MrToph commented Nov 10, 2020

Tree-shaking with react-icons using babel does not work and several megabytes of icon data is included, see issue #103.

Change Description

  • Removes react-icons and uses a different package that works with tree-shaking. See here

Reduces bundle size from 2MB to 319 KB.

API Changes

None

Documentation Additions

None

@MrToph MrToph mentioned this pull request Nov 10, 2020
Open
@kjg
Copy link

kjg commented Apr 20, 2021

Alternate approach in #112

@kjg kjg mentioned this pull request Apr 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrToph @kjg