Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b4b-dev: Plumber2 Implementation #2406
base: b4b-dev
Are you sure you want to change the base?
b4b-dev: Plumber2 Implementation #2406
Changes from 27 commits
7d061f9
a508497
11cafe6
fdbc70c
dd028a3
80e94fe
83b3ed5
0b6e209
7a0f7f2
dc44a68
459f0ce
e3e806e
1bca632
bf2dad3
c82efb8
d523301
cc2da4d
bc94326
1970863
df69f23
3e43097
f2e03b2
4e93b99
5164bb7
a7462b1
24897b3
0e8375a
b98f8ee
52c9786
aa06d7a
39b3023
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? I'll let you investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed these start and and years to be very clearly dummy years. I think this is necessary because the PlumberSite class must be implemented with a start/end time. However, this is changed later in the shell commands and is not a known parameter at the time of the object instantiation.
That said, if someone has a better suggestion for implementation, I'm all ears!