rtm1_0_85: Standardize time metadata #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate the 0th time step from RTM simulations slevis resolved conflicts: src/riverroute/RtmHistFile.F90
|
@slevis-lmwg reminder to self: |
…tadata Getting the updated ChangeLog.
Adding here separately to facilitate testing.
The RTM rpointer file now has the simulation timestamp in the filename Have the restart pointer filenames for RTM with the simulation time-stamp in them. Make it backwards compatible to using filenames without the simulation time-stamp as well. This changes time-manager setup from reading in the restart time from the restart file -- to using the current time sent from the coupler. Previously you would EITHER call timemgr_init OR timemgr_restart. Now, you always call timemgr_init -- and only call timemgr_restart for a restart case, with most of what it does is to make sure the time on the restart file agrees with the time sent from the coupler. Also remove use of shr_file_mod throughout the code. Change the ChangeLog file into a markdown file and start using some markdown syntax. Resolves: ESCOMP#53 Resolves: ESCOMP#46 PR ESCOMP#57
|
@samsrabin your rtm PR here is ready for me to merge. Could you have a look and approve, as you see fit? Thanks! |
|
Oh @samsrabin may not be eligible to approve his own PR. In fact I can probably approve it myself :-))) |
slevis-lmwg
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Changes here agree with ESCOMP/MOSART#66. I will initiate testing and then make a new tag.
PASS ./run_sys_tests -s rtm -c rtm1_0_84-ctsm5.3.019 -g rtm1_0_85-ctsm5.3.019
slevis-lmwg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Standardizes a dimension name of output variable
time_bounds, as well as attributes for that plusmcdate,mcsec,mdcur, andmscur.Specific notes
Contributors other than yourself: @phillips-ad, @ekluzek
RTM Issues Fixed:
Are answers expected to change (and if so in what way)? No.
Any User Interface Changes (namelist or namelist defaults changes)? No.
Testing performed
New metadata in a history file from a short test:
An arbitrarily-chosen CTSM test,
ERS_D_Ld5.f10_f10_mg37.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnFloodOnEffvelOn, passed bit-for-bit against tagctsm5.1.dev130, despite the changed metadata.