update qneg namelist standard name #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
reviewed
Mar 6, 2024
nusbaume
approved these changes
Mar 7, 2024
cacraigucar
reviewed
Mar 11, 2024
| @@ -81,7 +81,7 @@ | |||
| <type>char*8</type> | |||
| <category>diagnostics</category> | |||
| <group>qneg_nl</group> | |||
| <standard_name>print_qneg_warn</standard_name> | |||
| <standard_name>control_for_negative_constituent_warning</standard_name> | |||
There was a problem hiding this comment.
Totally pedantic question - how do we find control_for_negative_constituent_warning? In the spreadsheet, the standard name is "blank", even though the "Accepted" column is filled in. Going back to previous versions, I see "print_qneg_warn" as being accepted.
|
OK - I see it in the official repo (but I'm not sure if I would have equated it to qneg). I'll go ahead and add it into the spreadsheet. |
cacraigucar
approved these changes
Mar 11, 2024
|
@cacraigucar thanks for adding it to the spreadsheet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update print_qneg_warn standard name in qneg namelist.
...I guess I should have run a test before merging that last PR