ZM clean up round 2 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacraigucar
commented
Mar 15, 2024
nusbaume
requested changes
Apr 2, 2024
nusbaume
approved these changes
Apr 16, 2024
zhang_mcfarlane/zm_conv_momtran.F90
Outdated
Comment on lines
133
to
134
| real(kind_phys) :: pguall(ncol,pver,num_winds) ! Combined apparent force from updraft on PG U winds | ||
| real(kind_phys) :: pgdall(ncol,pver,num_winds) ! Combined apparent force from downdraft on PG U winds |
There was a problem hiding this comment.
I think on should be after PG here:
Suggested change
| real(kind_phys) :: pguall(ncol,pver,num_winds) ! Combined apparent force from updraft on PG U winds | |
| real(kind_phys) :: pgdall(ncol,pver,num_winds) ! Combined apparent force from downdraft on PG U winds | |
| real(kind_phys) :: pguall(ncol,pver,num_winds) ! Combined apparent force from updraft PG on U winds | |
| real(kind_phys) :: pgdall(ncol,pver,num_winds) ! Combined apparent force from downdraft PG on U winds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More cleanup identified during CCPP standard name meetings
Includes preliminary metadata for ZM (ignore for now as I know it is not complete - next review should include the entire files)
Closes #83