feature: direct support for __dump_gcov

- the previous implementation for dumping gcov statistics wasn't robust
  enough
- now, `__dump_gcov` is called directly from the signal handler and then
  `_exit` is called - this guarantees dumping of gcov statistics and
  immidiate module exit

Signed-off-by: aw <[email protected]>

cmake/ev-project-bootstrap.cmake

@@ -1,6 +1,6 @@
 set_property(
     GLOBAL
-    PROPERTY EVEREST_REQUIRED_EV_CLI_VERSION "0.4.0"
+    PROPERTY EVEREST_REQUIRED_EV_CLI_VERSION "0.4.5"
 )
 
 # FIXME (aw): clean up this inclusion chain

dependencies.yaml

@@ -86,7 +86,7 @@ ext-mbedtls:
 # everest-testing and ev-dev-tools
 everest-utils:
   git: https://github.com/EVerest/everest-utils.git
-  git_tag: v0.4.4
+  git_tag: feature/support_dump_gcov
 # linux_libnfc-nci for RFID
 libnfc-nci:
   git: https://github.com/EVerest/linux_libnfc-nci.git

lib/staging/helpers/CMakeLists.txt

@@ -8,6 +8,15 @@ target_sources(everest_staging_helpers
         lib/helpers.cpp
 )
 
+if (EVEREST_CORE_BUILD_TESTING)
+    target_compile_definitions(everest_staging_helpers PUBLIC EVEREST_COVERAGE_ENABLED)
+
+    target_sources(everest_staging_helpers
+        PRIVATE
+            lib/coverage.cpp
+    )
+endif()
+
 target_include_directories(everest_staging_helpers
     PUBLIC
         $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>

lib/staging/helpers/include/everest/staging/helpers/coverage.hpp

@@ -0,0 +1,5 @@
+#pragma once
+
+namespace everest::helpers {
+    void install_signal_handlers_for_gcov();
+}

lib/staging/helpers/lib/coverage.cpp

@@ -0,0 +1,38 @@
+#include <everest/staging/helpers/coverage.hpp>
+
+#include <atomic>
+
+#include <signal.h>
+#include <stdlib.h>
+#include <unistd.h>
+
+extern "C" void __gcov_dump();
+
+namespace {
+
+static std::atomic_flag going_to_terminate = ATOMIC_FLAG_INIT;
+
+void terminate_handler(int signal) {
+    if (going_to_terminate.test_and_set()) {
+        return;
+    }
+
+    __gcov_dump();
+
+    _exit(EXIT_FAILURE);
+};
+
+} // namespace
+
+namespace everest::helpers {
+
+void install_signal_handlers_for_gcov() {
+    struct sigaction action {};
+    action.sa_handler = &terminate_handler;
+    // action.sa_mask should be zero, so no blocked signals within the signal handler
+    // action.sa_flags should be fine with being zero
+    sigaction(SIGINT, &action, nullptr);
+    sigaction(SIGTERM, &action, nullptr);
+}
+
+} // namespace everest::helpers

tests/CMakeLists.txt

@@ -9,6 +9,10 @@ foreach(type MODULES LIBRARIES)
 
     foreach(target ${targets})
         append_coverage_compiler_flags_to_target(${target})
+
+        if (type STREQUAL "MODULES")
+            target_link_libraries(${target} PRIVATE everest::staging::helpers)
+        endif()
     endforeach()
 endforeach()