Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(coverage): documentation, register function reordering #1007

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

a-w50
Copy link
Contributor

@a-w50 a-w50 commented Jan 16, 2025

  • added unit tests for code coverage

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

- added unit tests for code coverage

Signed-off-by: aw <[email protected]>
Copy link
Contributor

@james-ctc james-ctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - the readme is very helpful

tests/README.md Outdated
The current sledgehammer approach is to manually delete the files in question or
just do (**be careful** with `rm` commands and wildcards!):
```bash
find ./build -name "*.gcno" | xargs rm
Copy link
Contributor

@james-ctc james-ctc Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about
find ./build -name '*.gcno' -delete
avoids using xargs
(same for .gcda)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , good one!

Signed-off-by: aw <[email protected]>
@a-w50 a-w50 merged commit cc46e47 into main Jan 17, 2025
11 checks passed
@a-w50 a-w50 deleted the refactor/target_coverage branch January 17, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants