Add withdraw authorization command in auth interface #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
force-pushed
the
refactor/auth-module-mutex-usage
branch
2 times, most recently
from
564c9ec to
887138e
Compare
Pietfried
force-pushed
the
feature/978-withdraw-authorization
branch
3 times, most recently
from
1a9c491 to
692e61a
Compare
Pietfried
requested review from
corneliusclaussen and
hikinggrass
as code owners
hikinggrass
approved these changes
Dec 20, 2024
| std::mutex event_mutex; | ||
| std::mutex withdraw_mutex; |
There was a problem hiding this comment.
this could probably also use the event_mutex now, or am I mistaken?
There was a problem hiding this comment.
Initially I thought so too. If we only use the event_mutex multiple withdraw requests could run in parallel and they could override this->withdraw_request in that case, because the event_mutex is released here while waiting for the targeted processing threads to finish. It ensures that only one withdraw_request can run at a time. Since a withdraw request should not block for a significant amount of time this seems to be the best solution to me
Pietfried
force-pushed
the
feature/978-withdraw-authorization
branch
2 times, most recently
from
adc0be8 to
7dac05d
Compare
* added operator overloading for ProvidedIdToken and IdToken types * Changed tokens_in_process from set of strings to set of ProvidedIdToken to be able to access the referenced connectors * Introduced processing_finished_cv in AuthHandler to be able to notify a withdraw request waiting thread that the processing of a token has finished * Implemented handle_withdraw_authorization function * Added test cases for new functionality * Move Deuathorized event in EvseManager so that its only published in case session is currently active Signed-off-by: Piet Gömpel <[email protected]> Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Pietfried
force-pushed
the
feature/978-withdraw-authorization
branch
from
53d86a8 to
929afb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a
withdraw_authorizationcommand in theauthinterface and the Auth module.Issue ticket number and link
#978
Checklist before requesting a review