Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #267 refactor unit tests #412

Merged
merged 75 commits into from
Jun 23, 2024
Merged

Issue #267 refactor unit tests #412

merged 75 commits into from
Jun 23, 2024

Conversation

Sanegv
Copy link
Member

@Sanegv Sanegv commented Jun 12, 2024

glhf

Sanegv and others added 30 commits February 26, 2024 19:41
@Sanegv
100% code coverage for int
5b2b0a1
@Sanegv
merging main
9df587d
@Sanegv
100% code coverage with char
b7f9c64
@Sanegv
merging main
4a6b1c9
@Sanegv
corrected a test and merge
b60916c
@Sanegv
almost finished bool coverage
768324e
@tot0p
Merge branch 'main' into issue-#267-refactor-unit-tests
769e6c2
@tot0p
update test bool for NewBool
8a457d1
@Sanegv
merging main
fd187bb
@Sanegv
100% coverage for bool
e7dd609
@Sanegv
quicksave
35a5be1
@Sanegv
merging main
1dc9d8a
@Sanegv
implemented tests for float with char
11a22cf
@Sanegv
merging main
d8d8ac9
@Sanegv
merging main
0813ad6
@Sanegv
finished error tests for float
47a3d4f
@Sanegv
100£ coverage for float
a30bff3
@Sanegv
almost done with null test
5f076ae
@Sanegv
merging main
4375582
@Sanegv
100% coverage for lib, and finished null
5f93e6d
@Sanegv
100% string coverage
d611a69
@Sanegv
quick save
c108f54
@Sanegv
solved conflict
32c7ecd
@Sanegv
max code coverage for any & commented wrong tests in float
39e0342
@Sanegv
started var test
a2029e6
@Sanegv
maximum code coverage for var
547c959
@Sanegv
commented the recursivity tests
aef78fa
@Sanegv
Merge branch 'main' into issue-#267-refactor-unit-tests
c35219e 
merging main
@Sanegv
implemented tests for new func & new anon func
ef8e7fe
@Sanegv
implemented all interface tests
14cbe55
Sanegv added 18 commits May 25, 2024 23:48
@Sanegv
maximum code coverage for List.go
22cbb34
@Sanegv
implemented all error unit tests for maps
a92f028
@Sanegv
implemented all tests for map
c12f7e9
@Sanegv
fixed the faulty unit test in function builtin
d264ca6
@Sanegv
Merge branch 'main' into issue-#267-refactor-unit-tests
6f18a92
@Sanegv
fixed broken unit tests
737b808
@Sanegv
Merge branch 'main' into issue-#267-refactor-unit-tests
d5dabbe
@Sanegv
Merge branch 'main' into issue-#267-refactor-unit-tests
c303518
@Sanegv
implemented UT for new error in map
cc9c31a
@Sanegv
Merge branch 'main' into issue-#267-refactor-unit-tests
28e1994
@Sanegv
72.9% code coverage for struct
e2e9d14
@Sanegv
Merge branch 'main' into issue-#267-refactor-unit-tests
765a21f
@Sanegv
setValue simple case tested
d10bb27
@Sanegv
Merge branch 'main' into issue-#267-refactor-unit-tests
ee21f62
@Sanegv
implemented the tests for set() in struct.go
02b9b1e
@Sanegv
Merge branch 'main' into issue-#267-refactor-unit-tests
4a5387e
@Sanegv
100% code coverage on struct.go
3c6fbef
@Sanegv
LAST COMMIT OF THIS BRANCH!!!!!
1f6edfb
@Sanegv Sanegv added urgent needs to be fixed urgently refactoring refactoring some code labels Jun 12, 2024
@Sanegv Sanegv requested review from tot0p, Llelepipede and mkarten June 12, 2024 21:19
@Sanegv Sanegv self-assigned this Jun 12, 2024
@Sanegv Sanegv linked an issue Jun 12, 2024 that may be closed by this pull request
refactor unit tests #267
Closed
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.75%. Comparing base (2241e11) to head (1f6edfb).

Files Patch % Lines
interpreter/eclaType/function.go 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #412       +/-   ##
===========================================
+ Coverage   55.97%   87.75%   +31.78%     
===========================================
  Files          38       38               
  Lines        5601     5601               
===========================================
+ Hits         3135     4915     +1780     
+ Misses       2314      555     -1759     
+ Partials      152      131       -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mkarten
mkarten approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@mkarten mkarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for merge in main

@tot0p tot0p merged commit 5980996 into main Jun 23, 2024
2 checks passed
@tot0p tot0p deleted the issue-#267-refactor-unit-tests branch June 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarten mkarten mkarten approved these changes

@tot0p tot0p tot0p approved these changes

@Llelepipede Llelepipede Awaiting requested review from Llelepipede

Assignees

@Sanegv Sanegv

Labels
refactoring refactoring some code urgent needs to be fixed urgently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor unit tests
3 participants
@Sanegv @tot0p @mkarten