Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llvm16 pr #23

Open
wants to merge 10 commits into
base: www
Choose a base branch
from
Open

Llvm16 pr #23

wants to merge 10 commits into from

Conversation

davidedelvento
Copy link
Contributor

Updating the docs augmenting (rather than replacing) the examples for LLVM16+ as discussed at EnzymeAD/Enzyme#1462

Note that the version of Enzyme that I am using, namely dc1c2696 (a few commits after v0.0.86) does not appear to be supporting the Cache behavior options so I have not updated that section and I have left a comment about it in the title (perhaps not clearest, please improve that part --as any other-- as you see fit)

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for dreamy-capybara-6a89db ready!

Name Link
🔨 Latest commit 76b81c9
🔍 Latest deploy log https://app.netlify.com/sites/dreamy-capybara-6a89db/deploys/65cc315dfe8dfb000833cd79
😎 Deploy Preview https://deploy-preview-23--dreamy-capybara-6a89db.netlify.app/getting_started/usingenzyme
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -64,12 +64,17 @@ entry:
...
```

## Performing AD Enzyme
## Performing AD Enzyme (the gory details)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe internals? Or on the inside

@@ -64,12 +64,17 @@ entry:
...
```

## Performing AD Enzyme
## Performing AD Enzyme (internal details)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps call it LLVM-native rather than internal defaults?

@@ -138,12 +143,29 @@ For ease, we could combine the final optimization and bianry execution into one
clang output.ll -O3 -o a.exe
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call this C++ native?

@wsmoses wsmoses self-requested a review February 14, 2024 01:44
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor wording changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants