Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): deprecated platform #53

Closed
wants to merge 172 commits into from

Conversation

TheAyes
Copy link

@TheAyes TheAyes commented Jan 6, 2025

Refactored the use of the deprecated symbol navigator.platform to use navigator.userAgentData/navigator.userAgent instead, which isn't deprecated and the current best practice of getting the user platform.

Since I neither use windows nor mac, someone would need to confirm that it's also working on there before considering merging.

  • Confirm working on Windows
  • Confirm working on Mac
  • Confirm working on Linux

Sorry, something went wrong.

thororen1234 and others added 30 commits July 13, 2024 02:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Metainfo for v2.0.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Metainfo for v2.0.1
thororen1234 and others added 19 commits October 21, 2024 16:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Insert release changes for v2.1.1

* Fixes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Added `.direnv` to the `.gitignore` file to prevent environment-specific configurations from being tracked. This change helps maintain a clean and portable repository.
Replaced direct use of `navigator.platform` with a new `getPlatform` function that utilizes `userAgentData` when available, improving compatibility with modern browsers. Added a fallback mechanism for older browsers to maintain functionality. Updated OS detection logic to use case-insensitive platform matching.
@TheAyes TheAyes marked this pull request as draft January 6, 2025 17:10
@TheAyes TheAyes closed this Jan 6, 2025
@TheAyes TheAyes deleted the refactor-deprecated-platform branch January 6, 2025 17:13
@TheAyes TheAyes restored the refactor-deprecated-platform branch January 6, 2025 17:17
@TheAyes TheAyes reopened this Jan 6, 2025
@verysillycat verysillycat deleted the branch Equicord:dev January 18, 2025 06:00
verysillycat added a commit that referenced this pull request Jan 18, 2025
@verysillycat
Copy link
Member

merged. super-seeded by d8fe37a

@verysillycat verysillycat changed the title Refactor deprecated platform refactor(utils): deprecated platform Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants