forked from Vencord/Vesktop
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(utils): deprecated platform #53
Closed
Closed
+2,479
−968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metainfo for v2.0.0
Metainfo for v2.0.1
This reverts commit 9ec0a25.
* Insert release changes for v2.1.1 * Fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Added `.direnv` to the `.gitignore` file to prevent environment-specific configurations from being tracked. This change helps maintain a clean and portable repository.
Replaced direct use of `navigator.platform` with a new `getPlatform` function that utilizes `userAgentData` when available, improving compatibility with modern browsers. Added a fallback mechanism for older browsers to maintain functionality. Updated OS detection logic to use case-insensitive platform matching.
merged. super-seeded by |
verysillycat
changed the title
Refactor deprecated platform
refactor(utils): deprecated platform
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the use of the deprecated symbol
navigator.platform
to usenavigator.userAgentData
/navigator.userAgent
instead, which isn't deprecated and the current best practice of getting the user platform.Since I neither use windows nor mac, someone would need to confirm that it's also working on there before considering merging.