Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pushdowns for unpivot #3724

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

universalmind303
Copy link
Contributor

closes #3722

Copy link

codspeed-hq bot commented Jan 25, 2025

CodSpeed Performance Report

Merging #3724 will improve performances by 16.54%

Comparing universalmind303:unpivot-optimizer (3ede568) with main (b31ad6b)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iter_rows_first_row[100 Small Files] 231 ms 198.2 ms +16.54%

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (98a5589) to head (3ede568).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3724      +/-   ##
==========================================
- Coverage   77.91%   77.04%   -0.87%     
==========================================
  Files         727      728       +1     
  Lines       91217    92552    +1335     
==========================================
+ Hits        71068    71311     +243     
- Misses      20149    21241    +1092     
Files with missing lines Coverage Δ
...lan/src/optimization/rules/push_down_projection.rs 93.61% <100.00%> (+0.71%) ⬆️

... and 10 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: applying a with_column after a melt/pivot errors
1 participant