Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-112-115-118-Modification-of-PaNET01236-PaNET01106-PaNET01196 #157

Conversation

spc93
Copy link
Collaborator

@spc93 spc93 commented Sep 4, 2024

ISS-112

Motivation:
'neutron single crystal diffraction' is not currently a subclass of 'neutron diffraction'

Mofification:
Current definition:
subclass of:
single crystal diffraction
neutron probe

Proposed new definition:
subclass of:
single crystal diffraction
neutron diffraction

Result:
Since 'neutron diffraction' is subclass of 'neutron probe' this change should only have the effect of making 'neutron single crystal diffraction' a subclass of 'neutron diffraction'.

Closes: #112

................

ISS-115

Motivation:
'obtain spatial map' is a subclass of 'defined by functional dependence'. This is wrong because 'obtain spatial map' (equivalent to 'imaging') may be obtained via a different functional dependence, e.g. a measurement in reciprocal space. The problem is in the definition of 'imaging'.

Modification:
Remove 'defined by functional dependence' from the definition of imaging.

Current definition:
subclass of:
'defined by functional dependence'
equivalent to:
obtain spatial map

New definition:
equivalent to:
obtain spatial map

Result:
Imaging (equivalent to 'obtain spatial map') is no longer a subclass of 'defined by functional dependence'

Closes: #115

................

ISS-118

Motivation:
'x-ray absorption spectroscopy' is not currently a subclass of 'x-ray absorption'

Modification:
Current definition:
subclass of:
x-ray probe
atomic core excitation
absorption spectroscopy

New definition:
subclass of:
x-ray absorption
atomic core excitation
absorption spectroscopy

Result:
Since 'x-ray absorption' is subclass of 'x-ray probe' this change should only have the effect of making 'x-ray absorption spectroscopy' a subclass of 'x-ray absorption'

Closes: #118

Motivation:
'neutron single crystal diffraction' is not currently a subclass of 'neutron diffraction'

Mofification:
Current definition:
subclass of:
single crystal diffraction
neutron probe

Proposed new definition:
subclass of:
single crystal diffraction
neutron diffraction

Result:
Since 'neutron diffraction' is subclass of 'neutron probe' this change should only have the effect of making 'neutron single crystal diffraction' a subclass of 'neutron diffraction'.

Closes: #112

................

ISS-115

Motivation:
'obtain spatial map' is a subclass of 'defined by functional dependence'. This is wrong because 'obtain spatial map' (equivalent to 'imaging') may be obtained via a different functional dependence, e.g. a measurement in reciprocal space. The problem is in the definition of 'imaging'.

Modification:
Remove 'defined by functional dependence' from the definition of imaging.

Current definition:
subclass of:
'defined by functional dependence'
equivalent to:
obtain spatial map

New definition:
equivalent to:
obtain spatial map

Result:
Imaging (equivalent to 'obtain spatial map') is no longer a subclass of 'defined by functional dependence'

Closes: #115

................

ISS-118

Motivation:
'x-ray absorption spectroscopy' is not currently a subclass of 'x-ray absorption'

Modification:
Current definition:
subclass of:
x-ray probe
atomic core excitation
absorption spectroscopy

New definition:
subclass of:
x-ray absorption
atomic core excitation
absorption spectroscopy

Result:
Since 'x-ray absorption' is subclass of 'x-ray probe' this change should only have the effect of making 'x-ray absorption spectroscopy' a subclass of 'x-ray absorption'

Closes: #118
@spc93 spc93 requested a review from paulmillar September 4, 2024 14:33
@spc93 spc93 merged commit 1ef8c35 into master Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants