SS-112-115-118-Modification-of-PaNET01236-PaNET01106-PaNET01196 #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISS-112
Motivation:
'neutron single crystal diffraction' is not currently a subclass of 'neutron diffraction'
Mofification:
Current definition:
subclass of:
single crystal diffraction
neutron probe
Proposed new definition:
subclass of:
single crystal diffraction
neutron diffraction
Result:
Since 'neutron diffraction' is subclass of 'neutron probe' this change should only have the effect of making 'neutron single crystal diffraction' a subclass of 'neutron diffraction'.
Closes: #112
................
ISS-115
Motivation:
'obtain spatial map' is a subclass of 'defined by functional dependence'. This is wrong because 'obtain spatial map' (equivalent to 'imaging') may be obtained via a different functional dependence, e.g. a measurement in reciprocal space. The problem is in the definition of 'imaging'.
Modification:
Remove 'defined by functional dependence' from the definition of imaging.
Current definition:
subclass of:
'defined by functional dependence'
equivalent to:
obtain spatial map
New definition:
equivalent to:
obtain spatial map
Result:
Imaging (equivalent to 'obtain spatial map') is no longer a subclass of 'defined by functional dependence'
Closes: #115
................
ISS-118
Motivation:
'x-ray absorption spectroscopy' is not currently a subclass of 'x-ray absorption'
Modification:
Current definition:
subclass of:
x-ray probe
atomic core excitation
absorption spectroscopy
New definition:
subclass of:
x-ray absorption
atomic core excitation
absorption spectroscopy
Result:
Since 'x-ray absorption' is subclass of 'x-ray probe' this change should only have the effect of making 'x-ray absorption spectroscopy' a subclass of 'x-ray absorption'
Closes: #118