Refactor: boundary conditions #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psakievich
requested review from
jrood-nrel,
alanw0,
overfelt,
rcknaus,
tasmith4 and
PaulMullowney
overfelt
approved these changes
Jul 13, 2022
PaulMullowney
approved these changes
Jul 13, 2022
psakievich
added a commit
that referenced
this pull request
Jul 13, 2022
This reverts commit f9a0fb9. More testing required
psakievich
added a commit
that referenced
this pull request
Jul 13, 2022
psakievich
added a commit
that referenced
this pull request
Jul 14, 2022
psakievich
added a commit
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General refactor of the boundary conditions data structures.
root()andparent()data structures from the boundary conditions and move to smart pointers. See Refactor: Remove parent() and root() #997 for why this is being pursued.BoundaryConditionsclass which is just a thin wrapper ofstd::vectorand is required for construction in a lot of places but never really used for anything other than astd::vector