-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more NEF compression details #2055
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2055 +/- ##
==========================================
- Coverage 61.48% 5.72% -55.77%
==========================================
Files 96 96
Lines 19207 18955 -252
Branches 9843 9843
==========================================
- Hits 11810 1085 -10725
- Misses 5080 17682 +12602
+ Partials 2317 188 -2129
Continue to review full report at Codecov.
|
426ea6a
to
7804e10
Compare
Looks fine to me. I would only add a comment indicating where the reader can find more information about those different options. Actually In this page from exiftool I see some values that are not added here (5, 7, 8): Why are you not adding those ones? |
Thanks for taking a look. Actually we got stuck at synchronizing the labels in exiftool/exiftool#117 |
Needs a rebase |
Actually, there is an unknown data struct behind a new MakerNote tag we don't support yet where these new values (13 & 14) come into play, hence the draft status... And there has been no conclusion of exiftool/exiftool#117 either. |
Found in newer Z bodies, as reported by exiftool