Remove exiv2json sample and tests depending on it #2183
Merged
+1
−2,125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2183 +/- ##
==========================================
- Coverage 63.30% 63.29% -0.02%
==========================================
Files 99 99
Lines 19596 19596
Branches 9559 9559
==========================================
- Hits 12406 12404 -2
- Misses 5116 5118 +2
Partials 2074 2074
Continue to review full report at Codecov.
|
clanmills
previously approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Thank You for dealing with this, Luis @piponazo.
I'm sad to see the death of the recursive parser that converts the XMPsdk output into JSON. That code is preserved in the archive of released code, and can be resuscitated in future. For now, it make sense to remove it from branch 'main'.
piponazo
force-pushed
the
mainRemoveJsonSample
branch
from
8857847 to
5b36ac5
Compare
nehaljwani
added a commit
to Exiv2/team
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed here the possibility to remove the exiv2json sample application which uses some old code borrowed from other repository and gave us some headaches in the past.
In this PR I am proposing the removal of such sample app and the tests depending on it.