Fix FileIO::Impl::switchMode fopen on windows #3007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same method to open file in `FileIo::Impl::switchMode` as is used in `FileIo::open` This allows wide-string std::fs::path obejcts to be read and written to on windows, without affecting other platforms
|
This is not the way to fix this IMHO. (I.e. one of the "real" fixes would be restoring the wide char API everywhere, not just here...) Instead, Windows clients of exiv2 0.28.x should now run in UTF-8 code page, where wide char API is irrelevant. |
|
Yes, i can see how much discussion there is around this issue. Thanks for the pointers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use same method to open file in
FileIo::Impl::switchModeas is used inFileIo::openThis allows wide-stringstd::fs::pathobejcts to be read and written to on windows, without affecting other platforms