Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to ktor v3 #914

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

chore: upgrade to ktor v3 #914

wants to merge 14 commits into from

Conversation

anssari1
Copy link
Contributor

@anssari1 anssari1 commented Dec 23, 2024 •
edited
Loading

Situation

  • Request bodies are not logged. Ktor 2 logging plugin does not work with gzipped content, so we created custom logging plugins. Ktor 3 resolved this issue.
  • EJMask uses static constructs, and therefore all clients share the same masking configuration under the hood. That being the case, configuring masked body fields on the client level does not work.

Action

  • Upgraded to Ktor 3
  • Removed custom logging plugins
  • Update pagination handling to do away with content decoding
  • Restructured logging functionality around EJMask to take into consideration its static constructs
  • Removed maskedLoggingBodyFields builder method

Testing

  • All unit tests fixed
  • Examples run

Results

  • Request bodies are logged
  • Ktor 3 performance improvements
  • Removed custom logging plugins
  • Masked logging body fields cannot be customized

Notes

@anssari1 anssari1 marked this pull request as ready for review January 15, 2025 10:08
@anssari1 anssari1 requested a review from a team as a code owner January 15, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anssari1