Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct apply_project in HttpRegistry #161

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: Correct apply_project in HttpRegistry #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sdk/python/feast/infra/registry/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,18 @@ def apply_project(
project: Project,
commit: bool = True,
): # type: ignore[return]
"""
We were not applying projects before the addition of the line below this comment.
When either validating features or trying to register them, the feature-store-feast-sdk would fail.
cli.py --> validate.py --> instantiating FeatureStore obj --> instantiating HttpRegistry obj --> apply_project()
No project was applied.
We then query the feature store registry and get back a 404 for the project.
Using apply_project_metadata(project.name) restores functionality.


Update this with correct implimentation for Project Objects later.
"""
self.apply_project_metadata(project.name)
return None

def delete_project(
Expand Down
Loading