Add elasticsearch online store - update method #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piket
force-pushed
the
feature/add_elastic_search_online_store
branch
from
f8783a6 to
9383ea9
Compare
| for i in range(n) | ||
| ] | ||
|
|
||
| index_param_list = [ |
There was a problem hiding this comment.
can you move this under the import section?
| if not resp.body: | ||
| self._create_index(es, fv) | ||
|
|
||
| def _create_index(self, es, fv): |
There was a problem hiding this comment.
move this to the bottom of the file
| ): | ||
| pass | ||
|
|
||
| def get_data_type(self, t: FeastType) -> str: |
There was a problem hiding this comment.
this could be private, right?
michaelbackes
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add Elasticsearch as an option for vector embeddings and features.
This implements the update method with full unit tests.