Unfold choice type slices when no unfolded elements match #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mint-thompson
approved these changes
Oct 13, 2023
cmoesel
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1337
This PR fixes a bug where if the choice type was referenced by slice name (i.e.
valueString) but there were other non-slice elements that could be unfolded, SUSHI would fail to ever unfold and find the choice type. This PR adds another place where choice type elements are unfolded so that all elements can be considered when finding a provided path.I ran a regression on all repos from the last year and there were not changes and no significant differences in processing time. That said, if anyone doesn't think this is the right approach to resolving this issue, let me know!