Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/elevator #5

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Feat/elevator #5

wants to merge 14 commits into from

Conversation

Kredcool
Copy link
Contributor

@Kredcool Kredcool commented Jan 23, 2025

very basic elevator stuff, before we merge we should:

  • update PID
  • add preset points
  • add controller input
  • check declaration of encoder (we may be using rev instead of ctre)

@KenwoodFox KenwoodFox changed the base branch from main to feat/magicbot January 23, 2025 19:08
Copy link
Member

@KenwoodFox KenwoodFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! This is clearly based on feat/magicbot and NOT main dont try to overmerge!
@dublUayaychtee you need to merge #2 this is the exact issue i warned about in my last review!

@Kredcool you dont support the fixes in #3 here, you'll need to wait for dylan to merge them or include them yourself in this pr.

@KenwoodFox
Copy link
Member

No! This STILL conflicts! @Kredcool check discord! You guys are gonna turn my hair grey 🥹

@FRC-1721 FRC-1721 deleted a comment from github-actions bot Jan 23, 2025
@FRC-1721 FRC-1721 deleted a comment from github-actions bot Jan 23, 2025
@KenwoodFox KenwoodFox added the new subsystem Entirely new subsytem or rewrite/large addon to existing subsystem. label Jan 23, 2025
@KenwoodFox KenwoodFox added this to the Week Zero milestone Jan 23, 2025
@KenwoodFox KenwoodFox deleted the branch main January 23, 2025 19:42
@KenwoodFox KenwoodFox closed this Jan 23, 2025
@KenwoodFox KenwoodFox reopened this Jan 23, 2025
@KenwoodFox KenwoodFox changed the base branch from feat/magicbot to main January 23, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new subsystem Entirely new subsytem or rewrite/large addon to existing subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants