Bgp connect refactor #17810
Merged
Bgp connect refactor #17810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldsharp
force-pushed
the
bgp_connect_refactor
branch
from
ad99350 to
65573cb
Compare
ton31337
approved these changes
Jan 9, 2025
bgpd/bgp_network.c
Outdated
| @@ -419,6 +419,7 @@ static void bgp_accept(struct event *thread) | |||
|
|
|||
| /* Accept client connection. */ | |||
| bgp_sock = sockunion_accept(accept_sock, &su); | |||
| zlog_debug("DBS: accepted: %pSUp", &su); | |||
bgpd/bgpd.h
Outdated
| @@ -1350,8 +1353,8 @@ struct peer { | |||
| char *update_if; | |||
| union sockunion *update_source; | |||
|
|
|||
| union sockunion *su_local; /* Sockunion of local address. */ | |||
| union sockunion *su_remote; /* Sockunion of remote address. */ | |||
| // union sockunion *su_local; /* Sockunion of local address. */ | |||
Let's make it so. Signed-off-by: Donald Sharp <[email protected]>
su_local and su_remote in the peer can change based upon if we are initiating the remote connection or receiving it. As such we need to treat it as a property of the connection. Signed-off-by: Donald Sharp <[email protected]>
Currently bgp is repeatedly grabbing peer connection information. This is a bit overkill. There are two situations: a) Opening a connection to the peer In this case, we know the remote port/address a priori and can get the local information by just asking the OS. b) Peer opening a connection to us. In this case, we know the local port/address a priori and can get the remote information by just asking the OS. Modify the code to just grab this data at the appropriate time. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
bgp_connect_refactor
branch
from
65573cb to
348c2dc
Compare
|
looks like CI is stuck |
|
ci:rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.