*: expose and fix variable shadowing warnings #17915
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 23, 2025 15:44
Start exposing variable-shadowing warnings in all builds. Signed-off-by: Mark Stapp <[email protected]>
Fix various "shadow" warnings in lib. Signed-off-by: Mark Stapp <[email protected]>
Clean up various "shadow" warnings. Signed-off-by: Mark Stapp <[email protected]>
Clean up various "shadow" warnings. Signed-off-by: Mark Stapp <[email protected]>
Clean up various "shadow" warnings.
donaldsharp
reviewed
Jan 23, 2025
| } | ||
|
|
||
| cpu_records_fini(old); | ||
| frr_mutex_lock_autounlock(&masters_mtx); |
There was a problem hiding this comment.
I don't see any changes in this chunk? What am I missing?
There was a problem hiding this comment.
yeah, this is one of the patterns that was a little awkward. note that the original had a with_mutex block, and then an inner with_mutex block. with_mutex is a macro, and it uses ... a local variable - so the inner block's variable shadows the outer block's. so the conversion replace the outer block, and that resolves the warning.
added 5 commits
January 24, 2025 14:44
Clean up various "shadow" warnings in babeld. Signed-off-by: Mark Stapp <[email protected]>
Clean up various variable-shadow warnings in bfdd. Signed-off-by: Mark Stapp <[email protected]>
Clean up various warnings from -Wshadow in eigrp. Signed-off-by: Mark Stapp <[email protected]>
Clean up various variable-shadow warnings in ldpd. Signed-off-by: Mark Stapp <[email protected]>
Clean up various variable-shadow warnings in mgmtd. Signed-off-by: Mark Stapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the -Wshadow warning option for builds; this exposes variable-shadowing issues. I've cleaned up several components, but some of the choices might be controversial (or ... awkward, or ... wrong), so I'm opening this as a draft to get some feedback before continuing with more components.