Improvements to --dep graph
#3411
Merged
+37
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtzguido
force-pushed
the
wip_depgraph
branch
from
557359d to
e828966
Compare
|
Updated on top of the current master, adding the rule to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some work in progress to make dependency graphs more useful. Mostly 1) distinguish between interface and implementation instead of just coallescing the modules, and 2) do not bring into the graph the implementation of modules if they are unneeded.
With this, the dependency graph for
FStar.Tactics.V2.fstgoes from:To:
Which allows to distinguish fst/fsti (e.g. we are not depending on
FStar.UInt32.fst). Marking as WIP since I ripped out the full cycle detection for this.