Add recommended versions endpoint #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamalam360
commented
Nov 14, 2021
| @@ -34,145 +34,170 @@ | |||
| @SuppressWarnings("Duplicates") | |||
| public class EndpointsV2 { | |||
|
|
|||
| public static void setup() { | |||
| public static void setup() { | |||
There was a problem hiding this comment.
Sorry about this diff, I must have pressed Ctrl Alt L in Idea and auto formatted everything
Jamalam360
commented
Nov 14, 2021
|
|
||
| for(MavenBuildVersion loader : FabricMeta.database.getLoader()){ | ||
| infoList.add(new LoaderInfoV2(loader, mappings).populateMeta()); | ||
| private static Object getRecommendedVersions(Context context) { |
Jamalam360
commented
Nov 14, 2021
| } | ||
|
|
||
| return versions; | ||
| } | ||
| return new RecommendedVersions(gameVersion, yarn.get(0), loader.get(0)); |
There was a problem hiding this comment.
It relies on the fact that the latest versions of yarn and loader are always first in the JSON - is this reliable?
Jamalam360
commented
Nov 14, 2021
| WebServer.jsonGet("/v2/versions/loader", context -> withLimitSkip(context, FabricMeta.database.getLoader())); | ||
| WebServer.jsonGet("/v2/versions/loader/:game_version", context -> withLimitSkip(context, EndpointsV2.getLoaderInfoAll(context))); | ||
| WebServer.jsonGet("/v2/versions/loader/:game_version/:loader_version", EndpointsV2::getLoaderInfo); | ||
| WebServer.jsonGet("/v2/versions/:game_version", context -> EndpointsV2.getRecommendedVersions(context)); |
There was a problem hiding this comment.
It could perhaps do with a better endpoint name
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint to fetch the data that is normally available at
https://fabricmc.net/versions.htmlthrough the API. It is marked as a draft as it needs some discussion - I'll self review it to add some comments on things that need addressing. It would be ideal if #10 was merged so that it could also provide FAPI?