-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more constant types #11
Conversation
fb34bde
to
b458391
Compare
Not sure that byte constants are working. Just tested this or with the entity status constants, and it did not work. The other unpicks work, though it could be the unpicks from that that are wrong |
@OroArmor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Can confirm that this is working with byte constants |
I've looked into |
Yeah, we probably won't use char as integertype. but we should still use them as literal types as they do exist in places like string concatenation, indexOf, etc. |
char simple constant support has been in this PR since the beginning |
Adds support for short, byte, and char simple constants; plus byte and short flag constants.
Boolean simple constant support is not included, as parameter names are adequate for giving
true
&false
meaning.Character flag constant support is not included, as chars aren't really meant to be used as integers, and only differ from shorts in that they are unsigned. I'm considering it though, Mojang does plenty of weird stuff.
Supersedes #5.