remove some now-unnecessary operations

src/v2/repository/pack.repository.ts

@@ -27,10 +27,7 @@ export default class PackFirestormRepository implements PackRepository {
 	async getWithSubmission(id: PackID): Promise<PackAll> {
 		const pack = await packs.get(id);
 		const submission = await this.submissionRepo.getById(id).catch<null>(() => null);
-
-		// faithful pack with no submission information found
-		if (!submission) return { ...pack, submission: {} };
-		return { ...pack, submission };
+		return { ...pack, submission: submission || {} };
 	}
 
 	async getAllTags(): Promise<string[]> {
@@ -109,8 +106,7 @@ export default class PackFirestormRepository implements PackRepository {
 	}
 
 	async update(packId: PackID, newPack: CreationPack): Promise<Pack> {
-		const packWithId = { ...newPack, [ID_FIELD]: packId };
-		await packs.set(packId, packWithId);
+		await packs.set(packId, newPack);
 		return packs.get(packId);
 	}
 

src/v2/repository/posts.repository.ts

@@ -1,4 +1,4 @@
-import { ID_FIELD, WriteConfirmation } from "firestorm-db";
+import { WriteConfirmation } from "firestorm-db";
 import { posts } from "../firestorm";
 import { CreateWebsitePost, WebsitePost, WebsitePostRepository, WebsitePosts } from "../interfaces";
 
@@ -32,17 +32,14 @@ export default class PostFirestormRepository implements WebsitePostRepository {
 		return results[0];
 	}
 
-	create(postToCreate: CreateWebsitePost): Promise<WebsitePost> {
-		const { permalink } = postToCreate;
-		return posts.add(postToCreate).then(() => this.getByPermalink(permalink));
+	async create(postToCreate: CreateWebsitePost): Promise<WebsitePost> {
+		await posts.add(postToCreate);
+		return this.getByPermalink(postToCreate.permalink);
 	}
 
-	update(id: number, post: CreateWebsitePost): Promise<WebsitePost> {
-		const postWithId = {
-			...post,
-			[ID_FIELD]: String(id),
-		};
-		return posts.set(id, postWithId).then(() => posts.get(id));
+	async update(id: number, post: CreateWebsitePost): Promise<WebsitePost> {
+		await posts.set(id, post);
+		return posts.get(id);
 	}
 
 	delete(id: number): Promise<WriteConfirmation> {

src/v2/repository/submission.repository.ts

@@ -1,4 +1,4 @@
-import { ID_FIELD, WriteConfirmation } from "firestorm-db";
+import { WriteConfirmation } from "firestorm-db";
 import {
 	SubmissionRepository,
 	Submission,
@@ -40,8 +40,7 @@ export default class SubmissionFirestormRepository implements SubmissionReposito
 	}
 
 	async update(packId: PackID, newPack: Submission): Promise<Submission> {
-		const packWithId = { ...newPack, [ID_FIELD]: packId };
-		await submissions.set(packId, packWithId);
+		await submissions.set(packId, newPack);
 		return submissions.get(packId);
 	}