Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): fix admin panel failing to build due to direct imports fr… #387

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

layaxx
Copy link
Member

@layaxx layaxx commented Nov 16, 2023

…om plugin-i18n

The i18n plugin has added the "exports" field to its package.json file, preventing direct import of some utilities that need here. Instead of the import, the needed functions are now added here directly with some minor modifications

fix #378

…om plugin-i18n

The i18n plugin has added the "exports" field to its package.json file, preventing direct import of
some utilities that need here. Instead of the import, the needed functions are now added here
directly with some minor modifications

fix #378
@layaxx layaxx requested a review from sargreal November 16, 2023 18:35
@layaxx layaxx linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec58e66) 45.95% compared to head (8afb7ba) 45.95%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   45.95%   45.95%           
=======================================
  Files          47       47           
  Lines         866      866           
  Branches      187      187           
=======================================
  Hits          398      398           
  Misses        310      310           
  Partials      158      158           
Flag Coverage Δ
unittests 45.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@layaxx layaxx merged commit 592e58f into main Nov 19, 2023
9 of 13 checks passed
@fekide-bot
Copy link

🎉 This PR is included in version 1.0.11 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.2.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.1.12 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Can't build strapi admin panel anymore
3 participants