Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Public dashboard security rules #1558

Closed
wants to merge 17 commits into from
Closed

feat: Public dashboard security rules #1558

wants to merge 17 commits into from

Conversation

solid-maxim
Copy link
Contributor

@solid-maxim solid-maxim commented Aug 10, 2021 •
edited
Loading

Fixes #1557

Checklist

  • Documented
  • Unit tested

@solid-maxim solid-maxim self-assigned this Aug 10, 2021
illia-romanenko
illia-romanenko suggested changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@illia-romanenko illia-romanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @solid-maxim. Added a couple of comments - let me know what you think. Glad that the structure that we have allows adding such checks so easily.

metrics/firebase/firestore/rules/firestore.rules Outdated Show resolved Hide resolved
metrics/firebase/firestore/rules/firestore.rules Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 16, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@solid-anatolyeva
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 16, 2021
@github-actions
@solid-anatolyeva has signed the CLA from Pull Request #1558
f6d0854
@solid-maksymtielnyi solid-maksymtielnyi changed the title feat: Public dashboard security rules feat: Public dashboard security rules, fix firebase_actions Aug 19, 2021
@solid-maksymtielnyi solid-maksymtielnyi changed the title feat: Public dashboard security rules, fix firebase_actions feat: Public dashboard security rules Aug 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@illia-romanenko illia-romanenko illia-romanenko requested changes

Assignees

@solid-maxim solid-maxim

@solid-maksymtielnyi solid-maksymtielnyi

@solid-anatolyeva solid-anatolyeva

Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Public Dashboard] Update Firestore security rules
4 participants
@solid-maxim @solid-anatolyeva @illia-romanenko @solid-maksymtielnyi