Move Mason Logger call during rebuild to avoid apparent logger race condition exception (Resolves #76) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Mason Logger call during rebuild to avoid apparent logger race condition exception (Resolves #76)
The original issue #76 looks like it was probably already fixed but I was running an older version of the static_shock_cli. I wasn't able to recreate the crash when running the latest version of the CLI from local sources.
I did, however, move the mason_logger log statement such that it never attempts to log anything until after we've verified that we're not already building the website. There seems to be some kind of race condition with the logger that's causing an exception. Rather than repeatedly catch that exception and warn the user, I moved the log statement to a safe location.
I filed felangel/mason#1280 with mason_logger.
This PR also upgrades mason_logger to
0.2.12, though this upgrade didn't solve the problem.