-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐️ Add entity embeddings workflow example #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for your patience with the review.
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Co-authored-by: Essam <[email protected]>
Kindly do let me know if I need to take any action here before it's merged. |
@EssamWisam Can you please rebase to see if that fixes your buildkite (GPU) fail? It's possible this was fixed by #284 but I'm not sure. |
Rebase entity-tutorial
Yes, it works now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Appreciate this valuable enhancement to the docs.
It dawned on me that entity embeddings is a noteworthy feature of this package and that it deserves a workflow example illustrating: (i), how it can be used and (ii), hints on how it works.
In particular, I was going to proceed with making an interface at MLJTransforms but felt I need to refresh my self on how this works first so I thought making this tutorial is a good way.