Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Add entity embeddings workflow example #278

Merged
merged 4 commits into from
Jan 20, 2025
Merged

⭐️ Add entity embeddings workflow example #278

merged 4 commits into from
Jan 20, 2025

Conversation

EssamWisam
Copy link
Collaborator

@EssamWisam EssamWisam commented Oct 26, 2024

It dawned on me that entity embeddings is a noteworthy feature of this package and that it deserves a workflow example illustrating: (i), how it can be used and (ii), hints on how it works.

In particular, I was going to proceed with making an interface at MLJTransforms but felt I need to refresh my self on how this works first so I thought making this tutorial is a good way.

@EssamWisam EssamWisam requested a review from ablaom October 26, 2024 03:08
@EssamWisam
Copy link
Collaborator Author

image

This seems to be the source of the test fail with the error being MLJBase.fit(model, 0, X, y) UndefRefError: access to undefined reference.

That said, I believe I have only modified the docs folder so that should be completely orthogonal on this fail.

@ablaom ablaom mentioned this pull request Oct 28, 2024
@ablaom ablaom closed this Nov 13, 2024
@ablaom ablaom reopened this Nov 13, 2024
Copy link
Collaborator

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your patience with the review.

@EssamWisam
Copy link
Collaborator Author

Kindly do let me know if I need to take any action here before it's merged.

@ablaom
Copy link
Collaborator

ablaom commented Dec 1, 2024

@EssamWisam Can you please rebase to see if that fixes your buildkite (GPU) fail? It's possible this was fixed by #284 but I'm not sure.

Rebase entity-tutorial
@EssamWisam
Copy link
Collaborator Author

@EssamWisam Can you please rebase to see if that fixes your buildkite (GPU) fail? It's possible this was fixed by #284 but I'm not sure.

Yes, it works now.

Copy link
Collaborator

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Appreciate this valuable enhancement to the docs.

@ablaom ablaom merged commit 178a52b into dev Jan 20, 2025
6 checks passed
@ablaom ablaom deleted the entity-tutorial branch January 20, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants