fix(sequelize-ds): allow user to create a record when there is a virtual field by removing it from the returned record #1223

Scra3 · 2024-12-02T15:06:16Z

linked to: CU-86c173ay7

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

forest-bot · 2024-12-02T15:07:14Z

Task linked: CU-86c173ay7 🔥🔥 P2 - Agent nodejs - Create - Virtual field on Sequelize throwing an error when a user want to create a row

Scra3 · 2024-12-02T15:51:05Z

packages/datasource-sequelize/test/collection.test.ts

@@ -115,7 +127,7 @@ describe('SequelizeDataSource > Collection', () => {
    };

    it('should delegate work to `sequelize.model.bulkCreate`', async () => {
-      const data = [{ data: 'data' }, { data: 10 }, { data: ['Enum'] }];


Data does not exist in the model. I replace it by existing fields.

codeclimate · 2024-12-03T09:14:21Z

Code Climate has analyzed commit 16b29ee and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2%.

View more on Code Climate.

realSpok

✅ PR title
✅ PR linked to the clickup task
✅ The PR tackle one subject only
✅ Destination branch
✅ Code review
- ✅ Use pure functions when possible
- ✅ Performance concerns
- ✅ Security concerns
✅ Automatic tests
- ✅ Unit tests
- ✅ Integration tests
✅ Manual tests
- ✅ Test the functionality
- ✅ Test error cases

## [1.11.18](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.11.18) (2024-12-03) ### Bug Fixes * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da))

## [1.5.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-03) ### Bug Fixes * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))

forest-bot · 2024-12-03T13:20:32Z

🎉 This PR is included in version 1.12.10 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.11.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-03) ### Bug Fixes * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))

forest-bot · 2024-12-03T13:20:35Z

🎉 This PR is included in version 1.11.18 🎉

The release is available on [email protected]

Your semantic-release bot 📦🚀

## [1.16.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-03) ### Bug Fixes * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf))

forest-bot · 2024-12-03T13:20:50Z

🎉 This PR is included in version 1.5.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-03T13:20:59Z

🎉 This PR is included in version 1.11.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-03T13:21:05Z

🎉 This PR is included in version 1.16.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-17T13:26:58Z

🎉 This PR is included in version 1.1.15 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# [1.56.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18) ### Bug Fixes * **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8)) * **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9)) * **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))

# [1.57.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18) ### Bug Fixes * **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8)) * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9)) * **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf)) * **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))

## [1.1.42](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18) ### Bug Fixes * **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8)) * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9)) * **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf)) * **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))

## [1.8.7](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18) ### Bug Fixes * **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8)) * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9)) * **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf)) * **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))

forest-bot · 2024-12-18T13:12:49Z

🎉 This PR is included in version 1.3.27 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# [1.45.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18) ### Bug Fixes * **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8)) * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9)) * **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf)) * **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))

# [1.36.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18) ### Bug Fixes * **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8)) * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9)) * **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf)) * **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))

## [1.4.10](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18) ### Bug Fixes * **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8)) * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9)) * **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf)) * **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))

# [1.4.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-12-18) ### Bug Fixes * **export-advanced:** compute filename on runtime ([#1229](#1229)) ([44082e8](44082e8)) * introduce agentCapabilities sub object ([#1222](#1222)) ([bce04f9](bce04f9)) * **security:** patch mongoose dependency vulnerabilities ([#1224](#1224)) ([d6197a9](d6197a9)) * **security:** patch path-to-regexp dependency vulnerabilities ([#1227](#1227)) ([839a4f3](839a4f3)) * **sequelize-ds:** allow user to create a record when there is a virtual field by removing it from the returned record ([#1223](#1223)) ([a7cb4da](a7cb4da)) ### Features * **capabilities:** add capabilities on get one projection ([#1221](#1221)) ([0909eaf](0909eaf)) * **native-query:** execute chart query requests ([#1225](#1225)) ([84b26dd](84b26dd))

forest-bot · 2024-12-18T13:13:25Z

🎉 This PR is included in version 1.56.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-18T13:13:55Z

🎉 This PR is included in version 1.57.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-18T13:14:25Z

🎉 This PR is included in version 1.1.42 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-18T13:14:52Z

🎉 This PR is included in version 1.8.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-18T13:15:49Z

🎉 This PR is included in version 1.45.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-18T13:16:22Z

🎉 This PR is included in version 1.36.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-18T13:16:43Z

🎉 This PR is included in version 1.4.10 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-12-18T13:17:04Z

🎉 This PR is included in version 1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Scra3 commented Dec 2, 2024

View reviewed changes

fix(sequelize-ds): remove virtual field when create a record

16b29ee

Scra3 force-pushed the fix-virtual-field-on-sequelize branch from e2f2232 to 16b29ee Compare December 3, 2024 08:27

realSpok approved these changes Dec 3, 2024

View reviewed changes

Scra3 merged commit a7cb4da into main Dec 3, 2024
22 checks passed

Scra3 deleted the fix-virtual-field-on-sequelize branch December 3, 2024 13:08

forest-bot added the released label Dec 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sequelize-ds): allow user to create a record when there is a virtual field by removing it from the returned record #1223

fix(sequelize-ds): allow user to create a record when there is a virtual field by removing it from the returned record #1223

Scra3 commented Dec 2, 2024 •

edited

Loading

forest-bot commented Dec 2, 2024

Scra3 Dec 2, 2024

codeclimate bot commented Dec 3, 2024

realSpok left a comment

forest-bot commented Dec 3, 2024

forest-bot commented Dec 3, 2024

forest-bot commented Dec 3, 2024

forest-bot commented Dec 3, 2024

forest-bot commented Dec 3, 2024

forest-bot commented Dec 17, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

fix(sequelize-ds): allow user to create a record when there is a virtual field by removing it from the returned record #1223

fix(sequelize-ds): allow user to create a record when there is a virtual field by removing it from the returned record #1223

Conversation

Scra3 commented Dec 2, 2024 • edited Loading

Definition of Done

General

Security

forest-bot commented Dec 2, 2024

Scra3 Dec 2, 2024

Choose a reason for hiding this comment

codeclimate bot commented Dec 3, 2024

realSpok left a comment

Choose a reason for hiding this comment

forest-bot commented Dec 3, 2024

forest-bot commented Dec 3, 2024

forest-bot commented Dec 3, 2024

forest-bot commented Dec 3, 2024

forest-bot commented Dec 3, 2024

forest-bot commented Dec 17, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

forest-bot commented Dec 18, 2024

Scra3 commented Dec 2, 2024 •

edited

Loading