-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fonts issue in printing #130
base: master
Are you sure you want to change the base?
Conversation
We must also support browsers that does not support fonts api (see font_loader in PDFJS) |
e4d90f5
to
6394bb6
Compare
The PDFJS library adds the fonts in the main document.fonts variable. So we need to passed those fonts to the iframe.
@FranckFreiburger I push a new fix using a div container instead of the iframe. Mostly because I have an issue with firefox with the Font API in the iframe. |
+1 on this PR. Tested on a local build of a project I'm working on, and the font issues we were seeing with printing are indeed fixed with this. @FranckFreiburger any thoughts on getting this in with a patch version bump? |
Finally, it's working. |
+1 for this PR. Tested locally and it works like a charm. |
why is this not merged yet? What's the best way for me to install these changes @arioth ? |
It solved my print problem. |
Thanks, it helped me too! |
After making this modification, a new issue arose where even though the entire print was good, only one page could be seen |
The PDFJS library adds the fonts in the main document.fonts variable. So we need to passed those fonts to the iframe.