-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): Builder pattern support for entities creation #4
Conversation
Wow, that looks nice! Maybe we can somehow get the json parser to also use this... |
|
||
@Override | ||
protected MultiDatastream getBuildingInstance() { | ||
return new MultiDatastream(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that supposed to be here? It'll return a new MultiDatastream each time...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups, well seen ;-) I fix it.
…rned a new instance each time it was called
@hylkevds thanks ;-) IMHO it is not necessary to use it within the JSON parser as you are using the Jackson library that provides lot of nice features based on your entity model. Those builders are more oriented to FROST-Client's users that want to manually create entities. |
@hylkevds, thanks. Could it be possible to release a 0.16 version that incorporates these changes? |
Done :) |
Thanks! Yes and the |
Good point... haven't heard back from JFrog/Bintray yet. I'll change the maven howto till they fix the issue. |
Hi,
Please accept this PR that adds the ability to use the Builder pattern during FROST-Client's
Entity
creation:In addition, any FROST-Client's entity builder can be extended. This way, FROST-Client clients could define their own way to construct OGC SensorThings' entities (by creating new FROST-Client's entity builders) and so could help to partially extend the FROST-Client's entity model (#3):
Finally, this PR includes:
Regards,
Aurélien