-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CVE-2024-28859 for SwiftMailer gadget chain in Symfony 1.x #715
Conversation
6.x: | ||
time: 2020-12-8 19:18:59 | ||
versions: ['>=6.0.0', '<6.30.0'] | ||
reference: composer://swiftmailer/swiftmailer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference: composer://swiftmailer/swiftmailer | |
reference: composer://friendsofsymfony1/swiftmailer |
(and the filename needs to be changed accordingly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @xabbuh , thank for you checks. reference
for the file swiftmailer/swiftmailer/CVE-2024-28859.yaml
corresponds to swiftmailer/swiftmailer
repository. But it is archived and there has been a fork. So I suggest maybe making 2 files for referencing both repositories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As they published a fork with a fix, I suggest adding a separate advisory for friendsofsymfony1/swiftmailer
(where 5.4.13 provides a patch for 5.x thanks to FriendsOfSymfony1/swiftmailer#18)
Co-authored-by: Christian Flothmann <[email protected]>
|
Hi @darkpills, maybe just adding the latest release as the upper bound? As it is unlikely that there will come a new release in the archived repository. But I'm not sure, if it's the way to go here. |
Aligning file path with composer paths Adding upper bounds for swiftmailer
@thirsch I added upper bounds and aligned file path with composer path. I also added another CVE. I think it should be ok now. |
Thank you @darkpills for taking care of this 👍 |
an unpatched vulnerability is supported. But you should have |
6.x: | ||
time: 2020-12-8 19:18:59 | ||
versions: ['>=6.0.0', '<6.30.0'] | ||
reference: composer://swiftmailer/swiftmailer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As they published a fork with a fix, I suggest adding a separate advisory for friendsofsymfony1/swiftmailer
(where 5.4.13 provides a patch for 5.x thanks to FriendsOfSymfony1/swiftmailer#18)
Co-authored-by: Christophe Coevoet <[email protected]>
Co-authored-by: Christophe Coevoet <[email protected]>
Merging swiftmailer 4.x and 5.x branch
@stof is this fine now? |
There is a deserialization gadget chain in SwiftMailer that impacts Symfony 1.x.
Adding this in both SwiftMailer and Symfony directories