Remove newline filter in param descriptions for agents #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
sidnarayanan
approved these changes
Jan 7, 2025
jamesbraza
reviewed
Jan 7, 2025
dosubot
bot
added
size:M
jamesbraza
approved these changes
Jan 7, 2025
| @@ -58,6 +58,7 @@ def many_edge_cases( | |||
| enum: StubEnum, | |||
| defaulted_str: str = "default", | |||
| defaulted_float: float = 1.0, | |||
| structured_arg: str = "structured", | |||
There was a problem hiding this comment.
Structured implies it's a BaseModel not a string, maybe rename to specified_str
|
@jamesbraza do you know what's up with this codeflash failure? |
Might be fixed by latest |
|
@jamesbraza nah still bugged, can I link them to this or do they not have access? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why we had this before. For agents with complex parameter descriptions (our only option for complicated tools since the tool description is limited to 1024 characters), this filter limits our ability to add structure.
So I'd like to cut it out.