Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 회원가입 #70

Merged
merged 2 commits into from
Feb 25, 2022
Merged

fix: 회원가입 #70

merged 2 commits into from
Feb 25, 2022

Conversation

uzhjd
Copy link
Collaborator

@uzhjd uzhjd commented Feb 25, 2022

What is this PR? 🔍

회원가입 기능

[수정 부분]

  • 데이터 저장 에러

    • 'signup'이라는 동일한 클래스들 존재 -> save할 수 있는 'SignUpController'제대로 동작 X
      -> 'signup'과 동일한 코드 삭제
      -> 'SignUpController'에서 'User'정보를 받아오는 것이 아닌 'UserRequest'의 정보로 회원가입이 되도록 변경
  • 생일, 전화번호 형 변환

    • 정규표현식 사용으로 인한 형 변환(int -> string)
  • swagger 작성

    • 회원가입 데이터관련 작성

Issue

#12

@uzhjd uzhjd merged commit acb9281 into GDSC-DEU:main Feb 25, 2022
@uzhjd uzhjd self-assigned this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant