Feat: 멤버 페이지 구현 #21
Merged
Feat: 멤버 페이지 구현 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seochan99
approved these changes
Apr 18, 2024
| > | ||
| <Image | ||
| src={BannerPng} | ||
| alt="BannerPng" |
Comment on lines
+21
to
+32
| <div className="text-4xl mb-[1.25rem]">Lead</div> | ||
| <div className='flex'> | ||
| <div className="text-3xl mr-[0.5rem]">서희찬</div> | ||
| <div className="text-2xl mb-[1.25rem]">컴퓨터공학과</div> | ||
| </div> | ||
| <div className="flex items-center text-lg"> | ||
| <div className="w-1 h-12 bg-white mr-2.5"></div> | ||
| <div> | ||
| 안녕하세요! GDSC DGU Lead 서희찬입니다. | ||
| <br/> | ||
| GDSC DGU는 많은 학우분들과 함께 성장하고 싶습니다. | ||
| 많은 관심 부탁드립니다! 감사합니다. |
Comment on lines
+22
to
+42
| const [selected, setSelected] = useState(1); | ||
|
|
||
| const handleCircleClick = (index: any) => { | ||
| if (index === 0) return; | ||
| setSelected(index); | ||
| onSelectIndex(index); // Pass the selected index up to the parent component | ||
| }; | ||
|
|
||
| const scrollContainer = useRef(null); | ||
|
|
||
| const getCircleColor = (index: any) => { | ||
| if (index === selected) return '#FB8C00'; | ||
| if (index < selected) return '#FFCC80'; | ||
| return '#9FA4A8'; | ||
| }; | ||
|
|
||
| const getTextColor = (index: any) => { | ||
| if (index === selected) return '#FFFFFF'; | ||
| return '#9FA4A8'; | ||
| }; | ||
|
|
There was a problem hiding this comment.
약간 이런 로직은 다른 파일로 뺼수없나 한번 봐야할듯!
|
metadata를 포기하면 됩니다 ㅎㅎ.ㅎ.ㅎ.ㅎ.ㅎ....ㅠㅠ |
shimseohyun
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )
개요
멤버 페이지 생성했습니다.
변경 사항
대략적인 뷰는 만들어놓고 타임라인 누를때마다 다른 세대 gdsc 나올수있게 세팅해놨습니다.
코드 확인받고나면 디자인은 피그마에 완전히 맞게 수정하고, 모바일 반응형 구현하겠습니다!
코드 리뷰시 참고 사항