✨Feat: Timeline 피드백 반영, Footer 제작, 폰트, 색상, 반응형 적용 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puretension
requested review from
seochan99,
bunju20,
naarang,
shimseohyun and
bianbbc87
puretension
added
🎨 Design
shimseohyun
approved these changes
Apr 27, 2024
| <h1 className="F1">About Us</h1> | ||
| <p className="F2">Final Update 2023.10.02</p> | ||
| <div className="flex items-center"> | ||
| <p className="F2">제작자 소개</p> |
There was a problem hiding this comment.
요기 제작자 소개 어디로 넘어기는지... 를 안 정했네요;; ㅎㅎ
정말 미안합니다...
일단 제안 주신 의견에 따라 저희 리드미로 할까요?
| className="w-10 h-8 bg-transparent border rounded-lg text-xs leading-4 px-2 py-1" | ||
| style={{ borderWidth: '1.5px', borderColor, color: textColor }} | ||
| className="border rounded-lg B2 px-3 py-0.5" | ||
| style={{ borderWidth: '1px', borderColor: isActive ? 'white' : '#536E7B', color: isActive ? 'white' : '#536E7B' }} |
There was a problem hiding this comment.
요거 grey 500이에요! 혹시 피그마에 수정이 안되었나요 ㅎㅎ 죄송해요....ㅎㅎ...................
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )
개요
배경색 검정 적용, Footer 있는 전체 화면
Footer
Tablet(768px) & Mobile(430px)
다른페이지에서 Footer 봣을때
변경 사항
Footer 생성, 전체 배경색 남색이었던거 검정으로 바꾸었고, 1차 PR 이후의 피드백 사항들(#18 + #24 + #25) 반영하여 코드 개선하였습니다. 전체뷰에 맞춰서 TimelinePage, TimelineCard, Footer등 반응형 적용했습니다!
코드 리뷰시 참고 사항
Footer의 제작자 소개에서 화살표 클릭했을때, 저희 README로 이동시키는건지, 아니면 제작자 보여주는 뷰가 있는건지 궁금합니다.
이젠 실제 데이터만 추가하면 끝인지, 아니면 추가적으로 다른 효과적용이 필요한지 궁금합니다(보시다시피 워낙 간단한 페이지라..🥲)
이전에 피드백주신 내용들 최대한 반영하봤는데 그래도 빠드린게 잇을거 같습니다.. 이번에도 Welcome Feedback!