-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Feat: Member 피드백 반영, 폰트, 색상, 반응형, favicon #38
Conversation
코드 깔끔하게 수정해야함.
GA해드릴게여.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고많으셨습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했어요~ 대괄호만 바꿔주고 머지하면될듯!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿잡입니다:₩
PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )
개요
반응형으로 수정
페비콘 추가
아래에서 검정색으로 세팅은 해놨는데, 혹시 몰라서 밝은 색도 이미지에 넣어놔서 바로 고칠수있게 만들어놨습니다.
변경 사항
#29 진행했습니다. 반응형으로 변경되도록, 파비콘, 폰트 및 색상 수정하였고 자잘한 디자인 수정 완료했습니다!
5/2일 모션 추가 완료했습니다.
코드 리뷰시 참고 사항
GA는 gdsc계정을 이후에 주시면 제가 달고, 메타데이터 썸네일 이슈로 서현님께서 썸네일 만드신뒤 진행하신다고 합니다! 피드백은 감사합니다!