update to work with boost 1.87 #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlptp
added
the
Installation/build
for more information, see https://pre-commit.ci
nightlark
reviewed
Dec 28, 2024
| const std::string_view result{boost::asio::buffer_cast<const char*>(buffer.data()), | ||
| // const std::string_view result{boost::asio::buffer_cast<const char*>(buffer.data()), | ||
| // buffer.size()}; | ||
| const std::string_view result{reinterpret_cast<const char*>(buffer.data().data()), |
There was a problem hiding this comment.
data() has to be called twice?
There was a problem hiding this comment.
the first one extracts a mutable buffer, the second one gets the void * pointer to the raw data. The second .data() is the replacement method for the buffer_cast. I looked at that twice too, but that appears to be the way to do it in this case.
nightlark
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will remove some usages of deprecated boost features which were removed in boost 1.87 now that we only support back to 1.73