Add HELICS 3.5.1 RECONNECTABLE handle option

[nightlark]

No description provided.

[phlptp]

The changes look fine but do we know why all the checks are failing?

[nightlark]

I don't see any connection between the test that is segfaulting and the changed enums.

[phlptp]

I don't either but probably isn't good that all the tests are failing?

[nightlark]

It seems to be the addition of the RECONNECTABLE option that is making them seg fault.

[phlptp]

those tests that are failing, check a return on the pythonic api that references the flags somehow. My guess is that is the issue somehow. And maybe that flag needs to get added to the pythonic api

[nightlark]

I'm not seeing a pythonic api wrapper that uses the options? The logs say it is failing on the call to create federate in the test https://github.com/GMLC-TDC/pyhelics/blob/main/tests/test_python_api.py#L70, and then in the HELICS C API function call: https://github.com/GMLC-TDC/pyhelics/blob/update-helics-3.5.1/helics/capi.py#L3712

[nightlark]

It's specifically when the line RECONNECTABLE = 412 # HelicsHandleOptions gets added to the class that it fails.

[phlptp]

well I am not opposed to leaving it out for the time being. That option was not needed for current python applications.

[nightlark]

Oh... I get it now. It was related to the assert -- some of the tests use repr to get a stringified representation of a Python object. I'm opening an issue to rewrite some of those test asserts; it seems like a quick way to check that the returned object is what is expected, but extremely fragile and makes adding a simple enum option require some not so intuitive updates to multiple API test asserts.