-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update add datagov_inventory extension #2681
Conversation
ansible/roles/software/ckan/inventory/templates/etc/ckan/production.ini
Outdated
Show resolved
Hide resolved
@@ -85,8 +85,9 @@ ckan.auth.user_create_organizations = false | |||
ckan.auth.user_delete_groups = false | |||
ckan.auth.user_delete_organizations = false | |||
ckan.auth.create_user_via_api = false | |||
ckan.auth.create_user_via_web = true | |||
ckan.auth.create_user_via_web = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FuhuXia can you confirm with the saml extension this is the correct setting? Or do we want something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of now, saml2 extension is using a separated production.ini template. So any time we make changes to production.ini file, the same changes need to be applied to ansible/roles/software/ckan/inventory/templates/inventory-next/etc_ckan_production.ini.j2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we should update inventory-next/etc_ckan_production.ini.j2 in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, although I doubt this will have any effect on saml login behaviour. But for consistency, we need to keep two production.j2 synchronized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated ansible/roles/software/ckan/inventory/templates/inventory-next/etc_ckan_production.ini.j2 with the changes.
This is related to #2575