Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add datagov_inventory extension #2681

Merged
merged 8 commits into from
Feb 11, 2021

Conversation

chris-macdermaid
Copy link
Contributor

This is related to #2575

@chris-macdermaid chris-macdermaid marked this pull request as ready for review January 25, 2021 22:11
@chris-macdermaid chris-macdermaid marked this pull request as draft January 26, 2021 22:43
@chris-macdermaid chris-macdermaid marked this pull request as ready for review February 8, 2021 15:46
@chris-macdermaid chris-macdermaid requested a review from a team February 8, 2021 15:46
@@ -85,8 +85,9 @@ ckan.auth.user_create_organizations = false
ckan.auth.user_delete_groups = false
ckan.auth.user_delete_organizations = false
ckan.auth.create_user_via_api = false
ckan.auth.create_user_via_web = true
ckan.auth.create_user_via_web = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FuhuXia can you confirm with the saml extension this is the correct setting? Or do we want something else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now, saml2 extension is using a separated production.ini template. So any time we make changes to production.ini file, the same changes need to be applied to ansible/roles/software/ckan/inventory/templates/inventory-next/etc_ckan_production.ini.j2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we should update inventory-next/etc_ckan_production.ini.j2 in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, although I doubt this will have any effect on saml login behaviour. But for consistency, we need to keep two production.j2 synchronized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ansible/roles/software/ckan/inventory/templates/inventory-next/etc_ckan_production.ini.j2 with the changes.

@adborden adborden self-assigned this Feb 11, 2021
@adborden adborden merged commit d88aebd into develop Feb 11, 2021
@adborden adborden deleted the feature/inventory-next-auth-extension branch February 11, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants