-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue-1032
Constraints
#1051
Open
Gabeblis
wants to merge
1
commit into
GSA:develop
Choose a base branch
from
Gabeblis:constraint/issue-1032
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
wandmagic
previously approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good nice work
needs rebase |
Gabeblis
force-pushed
the
constraint/issue-1032
branch
from
December 30, 2024 15:37
0e33c1e
to
65a1491
Compare
wandmagic
previously approved these changes
Dec 30, 2024
Gabeblis
force-pushed
the
constraint/issue-1032
branch
from
December 30, 2024 19:12
65a1491
to
6a2034b
Compare
Rene2mt
previously approved these changes
Dec 31, 2024
aj-stein-gsa
previously approved these changes
Dec 31, 2024
Gabeblis
force-pushed
the
constraint/issue-1032
branch
from
January 6, 2025 12:04
6a2034b
to
bdcc2c9
Compare
Rene2mt
requested changes
Jan 10, 2025
Gabeblis
force-pushed
the
constraint/issue-1032
branch
2 times, most recently
from
January 10, 2025 18:50
87a4270
to
8e5f6c9
Compare
Rene2mt
previously approved these changes
Jan 13, 2025
Gabeblis
force-pushed
the
constraint/issue-1032
branch
from
January 14, 2025 15:41
8e5f6c9
to
810cd77
Compare
conflicts need to be resolved |
Gabeblis
force-pushed
the
constraint/issue-1032
branch
from
January 15, 2025 14:13
810cd77
to
b5bc9f7
Compare
done 🫡 |
Gabeblis
force-pushed
the
constraint/issue-1032
branch
from
January 15, 2025 14:20
b5bc9f7
to
156f428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Purpose
This PR aims to add the
component-has-authenticated-scan
andinventory-item-has-authenticated-scan
constraints which help ensure that there is an "allow-authenticated-scan" prop in the inventory, and each Internal "service" component has "allows-authenticated-scan".Changes
Added constraints:
component-has-authenticated-scan
inventory-item-has-authenticated-scan
Added valid/invalid test content:
ssp-component-has-authenticated-scan-INVALID.xml
ssp-inventory-item-has-authenticated-scan-INVALID.xml
fedramp-ssp-example.oscal.xml
to align with constraints.Added yaml files for testing:
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.