Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue-1032 Constraints #1051

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to add the component-has-authenticated-scan and inventory-item-has-authenticated-scan constraints which help ensure that there is an "allow-authenticated-scan" prop in the inventory, and each Internal "service" component has "allows-authenticated-scan".

Changes

Added constraints:

  • component-has-authenticated-scan
  • inventory-item-has-authenticated-scan

Added valid/invalid test content:

  • ssp-component-has-authenticated-scan-INVALID.xml
  • ssp-inventory-item-has-authenticated-scan-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraints.

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 30, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 30, 2024 15:13
@Gabeblis Gabeblis linked an issue Dec 30, 2024 that may be closed by this pull request
17 tasks
wandmagic
wandmagic previously approved these changes Dec 30, 2024
Copy link

@wandmagic wandmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good nice work

@wandmagic
Copy link

needs rebase

wandmagic
wandmagic previously approved these changes Dec 30, 2024
Rene2mt
Rene2mt previously approved these changes Dec 31, 2024
aj-stein-gsa
aj-stein-gsa previously approved these changes Dec 31, 2024
@Gabeblis Gabeblis dismissed stale reviews from aj-stein-gsa and Rene2mt via bdcc2c9 January 6, 2025 12:04
@Gabeblis Gabeblis force-pushed the constraint/issue-1032 branch from 6a2034b to bdcc2c9 Compare January 6, 2025 12:04
@Gabeblis Gabeblis requested review from Rene2mt, wandmagic, aj-stein-gsa and a team January 10, 2025 16:08
@Gabeblis Gabeblis force-pushed the constraint/issue-1032 branch 2 times, most recently from 87a4270 to 8e5f6c9 Compare January 10, 2025 18:50
@Gabeblis Gabeblis requested a review from Rene2mt January 10, 2025 18:51
Rene2mt
Rene2mt previously approved these changes Jan 13, 2025
@wandmagic
Copy link

conflicts need to be resolved

@Gabeblis Gabeblis force-pushed the constraint/issue-1032 branch from 810cd77 to b5bc9f7 Compare January 15, 2025 14:13
@Gabeblis
Copy link
Contributor Author

conflicts need to be resolved

done 🫡

@Gabeblis Gabeblis requested a review from Rene2mt January 15, 2025 14:13
@Gabeblis Gabeblis force-pushed the constraint/issue-1032 branch from b5bc9f7 to 156f428 Compare January 15, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - Authenticated Scan Constraints
4 participants